tools/xenconsole: Use xc_domain_getinfo() correctly

Coverity ID: 1055018

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

diff --git a/tools/console/client/main.c b/tools/console/client/main.c
index 523fc23ed5baf1718cf0b731c06268b96c7be67c..38c856a11261519022ec5cc1017bd6700c7cff1a 100644 (file)
--- a/tools/console/client/main.c
+++ b/tools/console/client/main.c
@@ -339,7 +339,11 @@ int main(int argc, char **argv)
                xc_interface *xc_handle = xc_interface_open(0,0,0);
                if (xc_handle == NULL)
                        err(errno, "Could not open xc interface");
-               xc_domain_getinfo(xc_handle, domid, 1, &xcinfo);
+               if ( (xc_domain_getinfo(xc_handle, domid, 1, &xcinfo) != 1) ||
+                    (xcinfo.domid != domid) ) {
+                       xc_interface_close(xc_handle);
+                       err(errno, "Failed to get domain information");
+               }
                /* default to pv console for pv guests and serial for hvm guests */
                if (xcinfo.hvm)
                        type = CONSOLE_SERIAL;